build system: fix FEATURES_REQUIRED_ANY [backport 2021.01]#15967
Closed
maribu wants to merge 1 commit intoRIOT-OS:2021.01-branchfrom
Closed
build system: fix FEATURES_REQUIRED_ANY [backport 2021.01]#15967maribu wants to merge 1 commit intoRIOT-OS:2021.01-branchfrom
maribu wants to merge 1 commit intoRIOT-OS:2021.01-branchfrom
Conversation
Previously, FEATURES_REQUIRED_ANY didn't honor the order of the alternatives provided, if none of the features were already in used and multiple options are provided. This fixes this. (cherry picked from commit f41dcc9)
maribu
added
Area: build system
fjmolinas
requested changes
Feb 9, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
NACK, same issue as reported in #15855
FEATURES_REQUIRED_ANY="periph_i2c|periph_gpio" BOARD=samr21-xpro make -C examples/hello-world/ info-modules | grep periph_i2c
periph_i2c
periph_i2c should not be present, seems like the filter logic still has some issues :(
maribu
removed
the
CI: ready for build
Member
Author
|
This introduces a new issue, so let's close this and backport once all issues are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15957
Contribution description
Previously, FEATURES_REQUIRED_ANY didn't honor the order of the alternatives
provided, if none of the features were already in used and multiple options
are provided. This fixes this.
Testing procedure
See #15855 (comment)
Issues/PRs references
Found in #15855