sys/fmt: Add print_s64_dec to header#15979
Merged
MrKevinWeiss merged 3 commits intoRIOT-OS:masterfrom Feb 11, 2021
Merged
Conversation
maribu
approved these changes
Feb 10, 2021
Member
maribu
left a comment
There was a problem hiding this comment.
ACK. Thanks also for extending the test properly.
Member
|
Test output using |
Member
|
This should make the CI happy :-) diff --git a/tests/periph_ptp_clock/main.c b/tests/periph_ptp_clock/main.c
index f3afc03b73..22f82464d2 100644
--- a/tests/periph_ptp_clock/main.c
+++ b/tests/periph_ptp_clock/main.c
@@ -46,16 +46,6 @@
static mutex_t sync_mutex = MUTEX_INIT_LOCKED;
static atomic_uint_least64_t timestamp;
-static inline void print_s64_dec(int64_t _num)
-{
- uint64_t num = _num;
- if (_num < 0) {
- print_str("-");
- num = -_num;
- }
- print_u64_dec(num);
-}
-
static void speed_adj_cb(void *arg, int chan)
{
(void)arg; |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
It seems that
print_s64_decis implemented but not exposed in the header.This PR exposes it and improves coverage of the
fmtmodule.Testing procedure
make all test -C tests/fmt_print/CI should pass too.
Issues/PRs references
Split from #15950