cpu/fe310: set back newlib as default libc#15988
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Feb 12, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes a regression introduced by the combination of #15859 and #15957. Initially newlib was used as default libc on fe310 and the regression forces the use of picolibc.
For users with local toolchains providing newlib by default, this regression is a breaking change. Note that in recent Ubuntu versions, riscv64-unknown-elf is available in the package manager but it doesn't come with newlib and the package manager only provides picolibc. So it's not possible to use the riscv toolchain in the package manager of Ubuntu unless FEATURES_REQUIRED=picolibc is added to the build command. So this is not optimal but there's no good solution for all setup at the moment (until we have a way to automatically detect and use the available libc).
Testing procedure
this PR
master
Issues/PRs references
#15859 and #15957