drivers/at86rf2xx: add missing handler for TRX24_RX_START interrupt#16038
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Feb 18, 2021
Merged
Conversation
chudov
requested review from
daniel-k,
jia200x,
miri64 and
smlng
as code owners
Contributor
|
Verified PR on avr-rss2 (atmega256rfr2) with gnrc_networking_mac. |
benpicco
added
Area: drivers
kaspar030
added
CI: ready for build
Contributor
|
(pushed back in CI queue as this would fail anyway without #16042) |
maribu
added
CI: ready for build
Member
|
#16042 is now in. I restarted the build so that it indeed gets build on top of this, otherwise it would fail again. |
benpicco
approved these changes
Feb 18, 2021
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Nice, thank you!
I'll see if we can get rid of irq_status and directly call netdev_event as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Missing ISR's added to at86rf2xx_netdev.c for ATmegaRFA1/RFR2:
Testing procedure
Add one of ATMegaRFR2-based boards to BOARD_WHITELIST in tests\gnrc_gomach\Makefile or in examples\gnrc_networking_mac:
BOARD_WHITELIST := samr21-xpro iotlab-m3 derfmega256Run the test on 2 boards. Check that board with ATMegaRFR2 shows received packets
Issues/PRs references
Fixes #12857