Kconfig: make app.config and app.config.test mutually exclusive#16092
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Feb 26, 2021
Merged
Conversation
Contributor
|
As long as people know that they need to double the efforts until the migration is complete that is OK with me but I will let @leandrolanzieri have the final word. |
MrKevinWeiss
approved these changes
Feb 26, 2021
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
I guess nobody opposes the idea and the implementation seems sound so ACK!
Contributor
|
Lets holdoff on the merge for a second. Do other app.config parameter get used with app.config.test? |
Contributor
|
It looks like app.config only exists in some None of which contain a |
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When an application contains an
app.configfor configuration using Kconfig without dependency resolution and anapp.config.testfor configuration using Kconfig with dependency resolution, theapp.configfile is still loaded, setting legacy symbols, and this is causing errors with Kconfig (see e.g. #15951 (comment)). This makesapp.configandapp.config.testmutually exclusive and their selection as application base configuration based on the setting ofTEST_KCONFIG=1.Testing procedure
I cherry-picked this PR on top of #15951 and try to build the test there with and without
TEST_KCONFIG=1(currently causing an easy to solve merge conflict