Skip to content

riotctrl_shell.tests: add missing method to MockSpawn [backport 2021.01]#16142

Merged
aabadie merged 1 commit intoRIOT-OS:2021.01-branchfrom
miri64:backport/2021.01/dist/fix/riotctrl_shell-spawnmock-method-missing
Mar 4, 2021
Merged

riotctrl_shell.tests: add missing method to MockSpawn [backport 2021.01]#16142
aabadie merged 1 commit intoRIOT-OS:2021.01-branchfrom
miri64:backport/2021.01/dist/fix/riotctrl_shell-spawnmock-method-missing

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Mar 3, 2021

Backport of #16132

Contribution description

There was an update to riotctrl which introduced the usage of another method of pexpect's spawn class: read_nonblocking to flush the read output by pexpect. The mock we currently use in the tests for riotctrl_shell does not support that method which makes the CI action test-tools fail. This fixes that.

Testing procedure

test-tools should pass again.

Issues/PRs references

Follow up on RIOT-OS/riotctrl#21

@miri64 miri64 added Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Mar 3, 2021
This was referenced Mar 3, 2021
Merged
Merged
aabadie
aabadie approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit cc0d51b into RIOT-OS:2021.01-branch Mar 4, 2021
@miri64 miri64 deleted the backport/2021.01/dist/fix/riotctrl_shell-spawnmock-method-missing branch March 4, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabadie aabadie aabadie approved these changes

Assignees

No one assigned

Labels

Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @aabadie