gnrc_sixlowpan_frag_sfr: provide CongURE support by miri64 · Pull Request #16156 · RIOT-OS/RIOT

miri64 · 2021-03-05T14:25:44Z

Contribution description

This provides CongURE support for GNRC's 6LoWPAN SFR implementation and thus a to hook any CongURE congestion control implementation into SFR. The latter will be done in several follow-up PRs, this PR only adds the calling of the functions and tests to if the CongURE state machine is sane.

Testing procedure

Tests are provided in tests/gnrc_sixlowpan_frag_sfr_congure. They should pass

BOARD="<your choice>" make -C tests/gnrc_sixlowpan_frag_sfr_congure -j flash test

They are based mostly on tests/gnrc_sixlowpan_frag_sfr with some cleanup (and tests that do not check sending behavior removed) and additional checks for CongURE. I tried to provide reasoning for the checks in the comments. Please read them carefully.

Issues/PRs references

Depends on #16119 and #16133 and their respective dependencies.

miri64 · 2021-05-04T09:38:26Z

Rebased and squashed to current master. This PR does not have any dependencies anymore.

miri64 · 2021-05-06T15:12:33Z

Rebased again.

stale · 2022-03-02T13:18:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

riot-ci · 2022-10-12T11:46:18Z

Murdock results

✔️ PASSED

bc24f9a tests: add test for 6LoWPAN SFR using CongURE

Success	Failures	Total	Runtime
1996	0	1996	06m:36s

Artifacts

Documentation preview

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

miri64 · 2022-10-18T12:38:56Z

Rebased to current master.

benpicco

Open comments still apply 😉

tests/gnrc_sixlowpan_frag_sfr_congure/mockup_netif.c

sys/net/gnrc/network_layer/sixlowpan/frag/sfr/gnrc_sixlowpan_frag_sfr.c

benpicco

ACK, please squash

miri64 · 2022-10-25T16:38:59Z

Squashed

benpicco · 2022-10-26T20:44:05Z

Failure of tests/gcoap_fileserver should be unrelated.

miri64 · 2022-10-27T06:11:07Z

What was the error?

benpicco · 2022-10-27T13:02:35Z

The test uses randomness so probabilistic failures are possible.
We should just set a seed value there…

miri64 · 2022-10-27T13:41:22Z

The test uses randomness so probabilistic failures are possible.
We should just set a seed value there…

Yeah, or remove the randomness. ;-).

benpicco · 2022-10-27T13:51:26Z

Yea I mean that's what the seed value would do

miri64 · 2022-10-27T13:59:08Z

Yea I mean that's what the seed value would do

I know. But why is there randomness in a test (that does not test randomness) in the first place ;-).

benpicco · 2022-10-27T14:10:24Z

Because the test uses ZEP dispatcher with a set packet loss probability.

miri64 requested review from MrKevinWeiss and benpicco March 5, 2021 14:25

miri64 requested review from MichelRottleuthner, PeterKietzmann, aabadie, cgundogan, fjmolinas, haukepetersen, jia200x, leandrolanzieri and smlng as code owners March 5, 2021 14:25

miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 5, 2021

This was referenced Mar 5, 2021

embunit / unittests: several improvements #16145

Open

gnrc_sixlowpan_frag_sfr_congure_sfr: initial import #16158

Merged

miri64 mentioned this pull request May 4, 2021

congure_mock: add capability to provide actual methods #16133

Merged

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from 208aeea to 669caaa Compare May 4, 2021 09:38

miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 4, 2021

miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 4, 2021

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from 669caaa to a12b238 Compare May 4, 2021 11:35

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from a12b238 to e6d0f4d Compare May 6, 2021 15:12

MrKevinWeiss added this to the Release 2021.07 milestone Jun 22, 2021

MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from e6d0f4d to d4f03f0 Compare October 12, 2022 11:40

github-actions bot added Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 12, 2022

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from d4f03f0 to fe8d824 Compare October 18, 2022 12:38

benpicco reviewed Oct 18, 2022

View reviewed changes

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from bbef956 to cbf2b58 Compare October 25, 2022 10:32

kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2022

benpicco reviewed Oct 25, 2022

View reviewed changes

benpicco approved these changes Oct 25, 2022

View reviewed changes

miri64 added 2 commits October 25, 2022 18:38

gnrc_sixlowpan_frag_sfr: provide CongURE support

30f990f

gnrc_sixlowpan_frag_sfr: make ARQ timer mockable

b92e90f

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from 3e616d3 to bb5e982 Compare October 25, 2022 16:38

miri64 removed the State: waiting for maintainer State: Action by a maintainer is required label Oct 25, 2022

tests: add test for 6LoWPAN SFR using CongURE

bc24f9a

miri64 force-pushed the gnrc_sixlowpan_frag_sfr/feat/congure branch from bb5e982 to bc24f9a Compare October 26, 2022 07:12

miri64 enabled auto-merge October 26, 2022 13:49

benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 26, 2022

Conversation

miri64 commented Mar 5, 2021

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

miri64 commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented May 6, 2021

Uh oh!

stale bot commented Mar 2, 2022

Uh oh!

riot-ci commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

miri64 commented Oct 18, 2022

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

miri64 commented Oct 25, 2022

Uh oh!

benpicco commented Oct 26, 2022

Uh oh!

miri64 commented Oct 27, 2022

Uh oh!

benpicco commented Oct 27, 2022

Uh oh!

miri64 commented Oct 27, 2022

Uh oh!

benpicco commented Oct 27, 2022

Uh oh!

miri64 commented Oct 27, 2022

Uh oh!

benpicco commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

miri64 commented May 4, 2021 •

edited

Loading

riot-ci commented Oct 12, 2022 •

edited

Loading