gnrc_tcp: align with sock tcp#16493
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jul 13, 2021
brummer-simon:gnrc_tcp-align_with_sock_tcp
Merged
gnrc_tcp: align with sock tcp#16493benpicco merged 1 commit intoRIOT-OS:masterfrom brummer-simon:gnrc_tcp-align_with_sock_tcp
benpicco merged 1 commit intoRIOT-OS:masterfrom
brummer-simon:gnrc_tcp-align_with_sock_tcp
Conversation
brummer-simon
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
github-actions
bot
added
Area: network
benpicco
added
the
State: waiting for other PR
benpicco
removed
the
State: waiting for other PR
benpicco
reviewed
Jul 13, 2021
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
looks quite reasonable - please rebase
benpicco
added
the
CI: ready for build
Member
Author
|
Done |
benpicco
approved these changes
Jul 13, 2021
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Only adds getters and tests are still passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR implements all missing functions and API changes for SOCK_TCP integration to GNRC_TCP.
Testing procedure
All new functions and return codes are tested within the GNRC_TCP suite.
Just execute the tests under tests/gnrc_tcp
Issues/PRs references
Depends on PR #16459
Depends on PR #16461
Fixes #10664 - TCP Sockets can not be used / built