sys/auto_init: new auto_init_storage#16497
Closed
fabian18 wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
Conversation
5aa3ede to
801ef85
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Contributor
|
I think this is obsoleted by #17341. For things that then act more like infrastructure with many users (file systems, database) auto-init is the way to go. |
Contributor
Author
Yes kind of. I do not intend to pursue this PR any further. So closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
auto_init_storageto auto-initialize storage devices<d>shall be auto initialized if the pseudomoduleauto_init_storage_<d>is pulled inauto_initmodule shall setup the MTD device from deviceparamsauto_init_mtd_<d>auto_init_storage_at24cxxxas an exampleI´ll mark this as a draft because the implementation of the auto-initialization of the
at24cxxxshould probably be another PR.This PR could be just the
auto_init_storagemodule, if you agree with the code changes.Testing procedure
Board
sam54e-xprohas an MTDat24mac.Add to
boards/sam54e-xpro/board.c:Try
USEMODULE="mtd auto_init_storage_at24cxxx" BOARD=sam54e-xpro make -C examples/gnrc_networkingand verify that it is called. The board does not use the MTD for a special purpose, so this is just an example.A board that has to actually read or write something on auto-init must call
mtd_init()and do whatever it needs to do.I do not have that board but I have another board that is not in RIOT for which it works well.
Issues/PRs references
Similar as #11871