picolibc: Reset color in error message if picolibc is not available#16713
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Aug 5, 2021
Merged
picolibc: Reset color in error message if picolibc is not available#16713benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
Impact: minor
benpicco
approved these changes
Aug 5, 2021
benpicco
added
CI: skip compile test
This is a regression which was introduced in RIOT-OS#16114, without resetting the color the red color will be used for all following text written to the terminal and will also cause the shell prompt etc. pp. to be colored in red which is undesirable. This commit fixes this regression by using the ANSI escape sequences to reset the color after the error message has been written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression which was introduced in #16114 (CC: @fjmolinas), without resetting
the color the red color will be used for all following text written to
the terminal and will also cause the shell prompt etc. pp. to be colored
in red which is undesirable. This commit fixes this regression by using
the ANSI escape sequences to reset the color after the error message has
been written.