gnrc_tcp: Add GNRC_TCP_NO_TIMEOUT#16735
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Aug 14, 2021
brummer-simon:gnrc_tcp-add_GNRC_TCP_NO_TIMEOUT
Merged
gnrc_tcp: Add GNRC_TCP_NO_TIMEOUT#16735benpicco merged 1 commit intoRIOT-OS:masterfrom brummer-simon:gnrc_tcp-add_GNRC_TCP_NO_TIMEOUT
benpicco merged 1 commit intoRIOT-OS:masterfrom
brummer-simon:gnrc_tcp-add_GNRC_TCP_NO_TIMEOUT
Conversation
brummer-simon
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Aug 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds the constant GNRC_TCP_NO_TIMEOUT to disable user specified timeouts on the functions gnrc_tcp_accept, gnrc_tcp_send, gnrc_tcp_recv.
Testing procedure
This PR can be partially tested by executing the tests under tests/gnrc_tcp. Tests exist for gnrc_tcp_accept and gnrc_tcp_recv.
The function gnrc_tcp_send can't be tested because as soon as a connection was established the host system stores received data, therefore gnrc_tcp_send would be unblocked.
Issues/PRs references
Adds missing functionality required by #16494