gnrc_tcp: handle zero size buffers#16738
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Aug 14, 2021
brummer-simon:gnrc_tcp-handle_zero_size_buffers
Merged
gnrc_tcp: handle zero size buffers#16738benpicco merged 1 commit intoRIOT-OS:masterfrom brummer-simon:gnrc_tcp-handle_zero_size_buffers
benpicco merged 1 commit intoRIOT-OS:masterfrom
brummer-simon:gnrc_tcp-handle_zero_size_buffers
Conversation
brummer-simon
requested review from
PeterKietzmann,
cgundogan,
haukepetersen and
miri64
as code owners
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Aug 14, 2021
Member
Author
|
@benpicco: BTW: Thanks for reviewing my tcp PRs on a saturday. I appreciate it very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR enables gnrc_tcp_send and gnrc_tcp_recv to handle zero as buffer size parameter correctly.
Testing procedure
To verify this test, run the gnrc_tcp test suite located under: tests/gnrc_tcp.
A dedicated test for each function was added.
Issues/PRs references
Adds missing functionality required by #16494