lwip_tcp: fix build with DEVELHELP=0#16740
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Aug 16, 2021
Merged
Conversation
If DEVELHELP is not set `LOCK_TCPIP_CORE()`/`UNLOCK_TCPIP_CORE()` are not defined, leading to a build failure. Defining them to no-op leads to a run-time segmentation fault, so better always use those functions.
benpicco
added
the
Type: bug
github-actions
bot
added
Area: network
benpicco
added
Impact: minor
Contributor
|
Oops, sorry. This looks reasonable. |
fjmolinas
approved these changes
Aug 16, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
ACK, got the described build results without the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If DEVELHELP is not set
LOCK_TCPIP_CORE()/UNLOCK_TCPIP_CORE()are not defined, leading to a build failure.Defining them to no-op leads to a run-time segmentation fault, so better always use those functions.
Testing procedure
Compile the TCP echo examples from #16739 with
LWIP=1 DEVELHELP=0Issues/PRs references