boards/avr-rss2: properly enable atmega_pcint0

[leandrolanzieri]

Contribution description

For some reason the avr-rss2 defines a pseudomodule macro in board.h. This removes it.
EDIT: Now the module is enabled in Makefile.dep.

Testing procedure

• Green CI

Issues/PRs references

Introduced since the board port in #12668

[benpicco]

@herjulf what was the reason to add this?
Should it be

USEMODULE += atmega_pcint0

instead? (Or rather FEATURES_REQUIRED += atmega_pcint?)

[herjulf]

@herjulf what was the reason to add this? Should it be

USEMODULE += atmega_pcint0

instead? (Or rather FEATURES_REQUIRED += atmega_pcint?)

Yes you can remove from board.h. FEATURES_REQUIRED seems to be the best option.

[leandrolanzieri]

@herjulf what was the reason to add this? Should it be

USEMODULE += atmega_pcint0

instead? (Or rather FEATURES_REQUIRED += atmega_pcint?)

I went with the USEMODULE option, as it is the documented way:

RIOT/boards/common/atmega/doc.txt

Lines 12 to 13 in 3253d82

	To enable only a specific bank, simply add `USEMODULE += atmega_pcintN` to your
	Makefile. To enable all interrupts you can use `USEMODULE += atmega_pcint`.

[herjulf]

@herjulf what was the reason to add this? Should it be

USEMODULE += atmega_pcint0

instead? (Or rather FEATURES_REQUIRED += atmega_pcint?)

I went with the USEMODULE option, as it is the documented way:

RIOT/boards/common/atmega/doc.txt

Lines 12 to 13 in 3253d82

	To enable only a specific bank, simply add `USEMODULE += atmega_pcintN` to your
	Makefile. To enable all interrupts you can use `USEMODULE += atmega_pcint`.

OK. Noted. Thanks.