Makefile.base: do not clean objects of bindist modules#16981
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Oct 14, 2021
Merged
Conversation
leandrolanzieri
added
Type: bug
leandrolanzieri
requested review from
benpicco,
cgundogan,
fjmolinas and
kaspar030
benpicco
added
the
CI: ready for build
leandrolanzieri
added
CI: ready for build
Contributor
|
Looks good to me! Seems like this addresses what I saw on #16977. Thanks! |
benpicco
approved these changes
Oct 14, 2021
leandrolanzieri
deleted the
pr/build_system/do_not_cleanup_bindist_objects
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Since #16945 we cleanup unneeded object files. The list of "needed object files" is defined based on present source files, but bindist is a special case, as bindist objects should always be preserved. As described in #16977, the bindist example fails to link due to the cleanup. This PR avoids cleaning bindist modules object files when building.
Testing procedure
examples/bindistshould work (note that the binary check does not pass fornativeat least since the linking was fixed in build system: link object files #14754)Issues/PRs references
Fixes #16977
Issue introduced in #16945