tests/pthread_barrier: fix test script#17196
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Nov 16, 2021
Merged
Conversation
Previously the test script relied on the exact sequence of numbers returned by the used PRNG. This resulting e.g. in ``` $ USEMODULE=prng_musl_lcg make -C tests/pthread_barrier flash test ``` to fail, only because the order in which the children completed is slightly different due to different sleep durations. This fixes the issue.
Member
Author
|
I disabled compile tests (as this doesn't change C code). I think this will also skip builds and test runs for |
Member
Author
|
The race condition hit and Murdock is already almost through a full build. So at least on |
benpicco
approved these changes
Nov 16, 2021
Member
Author
|
Thanks for the review |
Member
|
I think the use of fstrings here broke CI hardware tests, possibly because the pi workers still use an old version of Python 3: |
Member
Author
|
Thanks for reporting. I'll wait a bit before PR'ing a fix to see if the Pis can be updated instead |
Member
|
For reference, fix is in #17283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Previously the test script relied on the exact sequence of numbers
returned by the used PRNG. This resulting e.g. in
to fail, only because the order in which the children completed is
slightly different due to different sleep durations. This fixes the
issue.
Testing procedure
The command above should succeed, no with and without
USEMODULE=prng_musl_lcgbefore the invocation ofmake.Issues/PRs references
Useful for #17188