Skip to content

drivers/ili9341/Kconfig: add feature to indicate hardware#17288

Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/drivers/ili9341/add_kconfig_feature
Dec 2, 2021
Merged

drivers/ili9341/Kconfig: add feature to indicate hardware#17288
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
leandrolanzieri:pr/drivers/ili9341/add_kconfig_feature

Conversation

@leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Nov 29, 2021

Contribution description

This adds a symbol to indicate the presence of an ili9341 display on a board in Kconfig. When present and MODULE_DISP_DEV is enabled, it enables the driver.

Testing procedure

Issues/PRs references

#17232

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Nov 29, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 29, 2021
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Nov 29, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 29, 2021
Merged
fjmolinas
fjmolinas approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 30, 2021
@fjmolinas fjmolinas enabled auto-merge November 30, 2021 07:10
fjmolinas
fjmolinas approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 30, 2021
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 2, 2021
@fjmolinas fjmolinas merged commit 215fb49 into RIOT-OS:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer

Projects

None yet

Milestone

Release 2022.01

Development

Successfully merging this pull request may close these issues.

4 participants

@leandrolanzieri @fjmolinas @kaspar030 @gschorcht