drivers/sx126x/Kconfig: rework model selection#17289
Merged
gschorcht merged 1 commit intoRIOT-OS:masterfrom Nov 30, 2021
Merged
drivers/sx126x/Kconfig: rework model selection#17289gschorcht merged 1 commit intoRIOT-OS:masterfrom
gschorcht merged 1 commit intoRIOT-OS:masterfrom
Conversation
leandrolanzieri
requested review from
MichelRottleuthner,
aabadie,
cgundogan,
fjmolinas,
jia200x and
smlng
as code owners
github-actions
bot
added
Area: drivers
fjmolinas
added
the
CI: ready for build
fjmolinas
approved these changes
Nov 29, 2021
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Makes sense, if Murdock is green lets merge.
Contributor
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Split from #17232. This rework how sx126x driver modules are selected, making the entry-point the driver module and using a choice for model selection, in combination with features to default to the correct option.
Testing procedure
Issues/PRs references
#17232