cpu/esp32: fix esp_wifi_enterprise compilation problem#17306
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Dec 1, 2021
Merged
Conversation
With the change from using archive files to using object files in PR RIOT-OS#14754, the module `esp_wifi_enterprise` was no longer compilable. The reason for this was that the file `bignum.c` was present in two different vendor sub-directories and created two identical object files, which then led to a symbol conflict when linking. This commit removes one of these identical files. The one that is used in all `esp_wifi` variants is kept, the one that is only used in `esp_wifi_enterprise` is dropped.
benpicco
approved these changes
Dec 1, 2021
Contributor
Author
|
Thanks for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the compilation problem for module
esp_wifi_enterprisereported in issue #17305.With the change from using archive files to using object files in PR #14754, the module
esp_wifi_enterprisewas no longer compilable. The reason for this was that the filebignum.cwas present in two different vendor sub-directories and created two identical object files, which then led to a symbol conflict when linking. This PR removes one of these identical files. The one that is used in allesp_wifivariants is kept, the one that is only used inesp_wifi_enterpriseis dropped.Testing procedure
Compile
Without this error it should show multiple definition errors like
With this PR the compilation should be successful. Since there is no code change successful compilation should be enough.
Issues/PRs references
Fixes #17305