makefiles: remove PCF857x pseudomodule definitions#17343
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Dec 5, 2021
Merged
makefiles: remove PCF857x pseudomodule definitions#17343aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie merged 1 commit intoRIOT-OS:masterfrom
Conversation
The pseudomodules used by the PCF7857x driver are correctly defined by `Makfefile.include` of the driver. However, by mistake they were left in `makefiles/pseudomodules.mk` when the very old PR was rebased to the current master. That is, they were only leftovers that have been overseen after rebasing an squashing dozens of fixup commits.
gschorcht
added
Area: drivers
aabadie
approved these changes
Dec 5, 2021
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Pseudomodules are defined in the driver Makefile.include.
ACK
Contributor
Author
|
@aabadie Thanks for reviewing. The PR was soooooo old and the make system has been changed a lot since that time 😟 |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
As the title says, the PCF7857x pseudomodule definitions that were accidentally added by PR #10430 are removed.
The pseudomodules used by the PCF7857x driver are correctly defined by the
Makfefile.includeof the driver. However, by mistake they were left inmakefiles/pseudomodules.mkwhen the very old PR was rebased to the current master. That is, they were only leftovers that have been overseen after rebasing an squashing dozens of fixup commits.Testing procedure
Compilation in Murdock succeed.
Issues/PRs references
Added with PR #10430