makefiles: avoid extra "/" when including files from external modules#17598
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Feb 1, 2022
Merged
Conversation
As the `dir` make function considers the last slash as part of the directory-part of a file name, we don't need to add an extra one.
leandrolanzieri
added
Type: bug
fjmolinas
added
the
CI: ready for build
maribu
approved these changes
Feb 1, 2022
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
I'm trusting @leandrolanzieri and Murdock on this one.
leandrolanzieri
deleted the
pr/makefiles/fix_external_module_paths_includes
branch
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
As the
dirmake function considers the last slash as part of the directory-part of a file name, we don't need to add an extra one. From the function documentation:Alternatively we can go the other way, and remove the slash from the variable. I took this path because of the natural way make seems to consider directory paths.
Testing procedure
tests/external_module_dirsshould work as usualIssues/PRs references
Spotted while reviewing #17596