Skip to content

tests/pkg_mbedtls: improve entropy test case and doc#17606

Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom
PeterKietzmann:pr_test_mbedtls_opt
Feb 8, 2022
Merged

tests/pkg_mbedtls: improve entropy test case and doc#17606
fjmolinas merged 2 commits intoRIOT-OS:masterfrom
PeterKietzmann:pr_test_mbedtls_opt

Conversation

@PeterKietzmann
Copy link
Member

@PeterKietzmann PeterKietzmann commented Feb 2, 2022

Contribution description

tests/pkg_mbedtls failed the entropy tests on some boards (compare this and this comment).

This PR applies the following changes:

  • Indicate when adc noise is the only source for the mbedtls entropy module. In this case, it can occur that the test fails due to improper ADC configurations and hardware properties.
  • The testrunner checks for the occurrence of "adc_noise_single_entropy" and does not wait for a successful entropy test result in this case.
  • Remove CI blacklisting introduced in tests/pkg_mbedtls-blacklist: blacklist samr21-xpro #17588.

Testing procedure

  • Execute tests/pkg_mbedtls on boards (samr21-xpro and nucleo-l152re in particular) and native using make test.
  • CI passes execution on hardware.

Issues/PRs references

#15671, #17588

@PeterKietzmann PeterKietzmann added Area: tests Area: tests and testing framework Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: security Area: Security-related libraries and subsystems CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Feb 2, 2022
@github-actions github-actions bot removed the Area: pkg Area: External package ports label Feb 2, 2022
@PeterKietzmann PeterKietzmann changed the title tests/pkg_mbedtls: improce entropy test case and doc tests/pkg_mbedtls: improve entropy test case and doc Feb 2, 2022
@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 4, 2022
benpicco
benpicco approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Let's see what CI says

@PeterKietzmann
Copy link
Member Author

PeterKietzmann commented Feb 8, 2022

green...

@fjmolinas fjmolinas merged commit bd5ab86 into RIOT-OS:master Feb 8, 2022
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

No one assigned

Labels

Area: security Area: Security-related libraries and subsystems Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR

Projects

None yet

Milestone

Release 2022.04

Development

Successfully merging this pull request may close these issues.

4 participants

@PeterKietzmann @benpicco @OlegHahm @fjmolinas