buildsystem: split default modules include early and late#17662
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Jun 2, 2022
Merged
buildsystem: split default modules include early and late#17662maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
fjmolinas
added
the
CI: ready for build
maribu
reviewed
Feb 16, 2022
Contributor
Author
|
I ran @maribu Is there anything to look at besides naming? I'm personally in favor of your descriptive long names, but would rather get all the nitpicks at once since the build is already passing, I want to do only one more build. |
fjmolinas
force-pushed
the
pr_default_modules_early_late
branch
from
542f69b to
b981061
Compare
Contributor
Author
|
Ping @maribu! |
fjmolinas
force-pushed
the
pr_default_modules_early_late
branch
from
b981061 to
f8e5f6e
Compare
Contributor
Author
|
IMO this is really only a cleanup, but better to have a specific file for this as well |
benpicco
approved these changes
Jun 1, 2022
Member
|
CI passes except for two bogus hash mismatches due to unreproducible builds with ESP. Let's run the CI again without compile tests. |
maribu
added
CI: skip compile test
Member
|
@fjmolinas: Please squash ;) |
fjmolinas
force-pushed
the
pr_default_modules_early_late
branch
from
f8e5f6e to
fbe9ad0
Compare
Contributor
Author
|
Squashed! |
fjmolinas
added
CI: ready for build
DEFAULT_MODULEs declared in defaultmodules_regular.inc.mk MAY only be disabled at APPLICATION level or in BOARD/CPU Makefile.default. These modules MAY have complex dependencies themselfs. DEFAULT_MODULEs declared in defaultmodules_no_recursive_deps.inc.mk MAY be disabled during dependency resolution. The MUST only have dependencies against modules with no dependencies themselfs, and these dependencies must be defined in makefiles/defaultmodules._deps.inc.mk
Contributor
Author
|
Rebased to get the pthon fix in. |
fjmolinas
force-pushed
the
pr_default_modules_early_late
branch
from
fbe9ad0 to
b5197db
Compare
Member
|
Last full CI run is from yesterday --> recent enough. |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is merely a cleanup from #17632, with #17584, more modules would be added as DEFAULT_MODULEs only at the end. So this PR adds a file to cumulate those as well as renaming the file introduced in #17632 so that naming aligns.
Testing procedure
Green murdock should be enough here.