Skip to content

tests: add default BOARDS#17715

Merged
fjmolinas merged 3 commits intoRIOT-OS:masterfrom
kfessel:p-add-building-default
Mar 1, 2022
Merged

tests: add default BOARDS#17715
fjmolinas merged 3 commits intoRIOT-OS:masterfrom
kfessel:p-add-building-default

Conversation

@kfessel
Copy link
Contributor

@kfessel kfessel commented Feb 28, 2022 •
edited
Loading

Contribution description

This adds a building default Board to many tests that are currently missing one

Why?

when working on #17693 ( the part that has become #17714) I wanted to build ~all Tests (for any BOARD) - prior to uploading that for murdock to do the same for all boards, and some of them did just fail because they where build for native, because there was no Board set

Details Makefile i used (copied to examples or tests)

https://gist.github.com/kfessel/9af890ddf7e7088cec9acbddbda4ebdb

Testing procedure

$ make -C <some test>

Example:

before PR

$ make -C tests/periph_dma
make: Entering directory ' ... /tests/periph_dma'
There are unsatisfied feature requirements: periph_dma

after PR

$ make -C tests/periph_dma
make: Entering directory '... /tests/periph_dma'
Building application "tests_periph_dma" for "samr34-xpro" with MCU "saml21".

Issues/PRs references

was in #17693

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Feb 28, 2022
@kfessel kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 28, 2022
@kfessel kfessel mentioned this pull request Feb 28, 2022
Closed
@github-actions github-actions bot added the Area: examples Area: Example Applications label Feb 28, 2022
@kfessel kfessel mentioned this pull request Feb 28, 2022
Closed
fjmolinas
fjmolinas approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, native as default does not make sense for those tests.

@fjmolinas fjmolinas enabled auto-merge March 1, 2022 09:23
@fjmolinas fjmolinas merged commit 945dd08 into RIOT-OS:master Mar 1, 2022
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

Assignees

No one assigned

Labels

Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2022.04

Development

Successfully merging this pull request may close these issues.

3 participants

@kfessel @fjmolinas @OlegHahm