sys/gnrc/sixlowpan/frag/fb: guard sfr_types.h header include#17730
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Mar 2, 2022
Merged
sys/gnrc/sixlowpan/frag/fb: guard sfr_types.h header include#17730kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
Conversation
The included header references evtimer which is not a direct dependency for gnrc_sixlowpan_frag, but only for gnr_sixlowpan_frag_sfr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This guards the header.
Testing procedure
ztimer_xtimer_compat(no 64bit), which exposed the wrongful inclusion.USEMODULE=ztimer_xtimer_compat make -C tests/gnrc_sixlowpan_frag -jNote: the above command still yields an error, but will be fixed in another PR.
Issues/PRs references
Found in #17365