sys/syscalls: make gettimeofday() implementation optional#17733
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Mar 24, 2022
Merged
sys/syscalls: make gettimeofday() implementation optional#17733fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
Conversation
1a64bc1 to
0a5be52
Compare
4ea3423 to
9bd2011
Compare
e285c2a to
f2bd476
Compare
Contributor
Author
f2bd476 to
0c5a316
Compare
417b260 to
9b7ed6f
Compare
Contributor
Author
|
@kaspar030 @kfessel all green here, would be good to get this in to reduce ztimer64 users! |
kfessel
reviewed
Mar 23, 2022
Contributor
kfessel
left a comment
There was a problem hiding this comment.
I think the pseudo module could have a shorter name. libc_gettimeofday
618c761 to
c7fce7c
Compare
Contributor
Author
|
@kfessel changes addressed! |
Conditionally implement gettimeofday() if module is included, this avoids including ztimer64 even when not needed
c7fce7c to
0819660
Compare
kfessel
approved these changes
Mar 24, 2022
Contributor
|
This breaks esp32 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Contribution description
A follow-up to #17732 to not force 64bit on all syscalls users.
With this PR the users of ztimer64 should be limited to:
Revisited list of apps using
ztimer64:for app in examples/* tests/*; do make -C ${app} info-modules | if grep -q ztimer64; then echo ${app};fi;doneTesting procedure
Green Murdock, although should probably wait for #17721 or cherry-pick f7f7a93 to test for missing dependencies.
Issues/PRs references
Follow up to #17732
Related to #17721 and #17365