You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #16688 was merged I tried to port the examples to used URIs (utilizing the uri_parser) module, which was halted, since netutils_get_ipv6() requires a string (\0 terminated char array) and not a char buffer (a char array + length), the latter being the output of the non-destructive uri_parser. Maybe in the design of netutils_get_ipv4() this lack in the original netutils_get_ipv6() can already be addressed?
After #16688 was merged I tried to port the examples to used URIs (utilizing the uri_parser) module, which was halted, since netutils_get_ipv6() requires a string (\0 terminated char array) and not a char buffer (a char array + length), the latter being the output of the non-destructive uri_parser. Maybe in the design of netutils_get_ipv4() this lack in the original netutils_get_ipv6() can already be addressed?
Unfortunately it can't, because the root of the problem is that sock_dns_query, which is used by netutils_get_ipv4 and netutils_get_ipv6, requires a null-terminated string .
Unfortunately it can't, because the root of the problem is that sock_dns_query, which is used by netutils_get_ipv4 and netutils_get_ipv6, requires a null-terminated string .
That sounds also like a fixable problem ;-), but I can understand if you are not willing to do it here. :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Add function
netutils_get_ipv4()tonetutils.Testing procedure
Existing test in
tests/netutilswas extended.Can be tested with #17763