sys/net/gnrc/sock: use ztimer_usec or xtimer for timeout#17852
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Mar 24, 2022
Merged
sys/net/gnrc/sock: use ztimer_usec or xtimer for timeout#17852fjmolinas merged 1 commit intoRIOT-OS:masterfrom
fjmolinas merged 1 commit intoRIOT-OS:masterfrom
Conversation
kfessel
approved these changes
Mar 24, 2022
Contributor
kfessel
left a comment
There was a problem hiding this comment.
change matches ztimer for xtimer 1:1, murdock is green; and successful test results are provided
Contributor
Author
|
Go! thanks for the review! |
miri64
reviewed
Mar 24, 2022
| } | ||
| #ifdef MODULE_XTIMER | ||
| #if IS_USED(MODULE_ZTIMER_USEC) | ||
| ztimer_t timeout_timer; |
Member
There was a problem hiding this comment.
This is a problem with xtimer as well, but this initialization might be with garbage in base.next ;-). Was about to provide a fix for that anyway any moment (just testing something before-hand), so I will just piggy-back an initializer here as well ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Split as from #17836 as requested in #17836 (comment).
Sure with
ztimer_usecbeing no the default I could have just removedxtimer, but this works as well, and I already did it, so its less work to keep as is.Testing procedure
murdock should be enough
local tests
for app in tests/gnrc_sock_udp tests/gnrc_sock_ip; do USEMODULE=ztimer_usec RIOT_CI_BUILD=1 make -C ${app} flash test test-as-root -j; doneIssues/PRs references
#17111