vfs: fall back to fstat() if stat() is not implemented#17966
Closed
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
vfs: fall back to fstat() if stat() is not implemented#17966benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
benpicco wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Member
|
TODO: Which filesystem implements `fstat()` but not `stat()`?
If it's not certain that any fs needs this at all, might the better way be requiring fstat to be present when stat is present, and if needed, provide a generic stat impl that FSs can place in their driver?
|
Contributor
Author
|
Oh we already have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Instead of making the application work around this (as #14397 did) implement this in vfs so that
vfs_stat()always works independent of the filesystem.Testing procedure
TODO: Which filesystem implements
fstat()but notstat()?Issues/PRs references