examples/dtls-echo: set address family for sessions#18369
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jul 26, 2022
Merged
examples/dtls-echo: set address family for sessions#18369miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
d424aae introduced address families to the RIOT interpretation of tinydtls-`session_t`s. However, while fixing the naming for the `addr` field, it did not set the `family` member for the sessions in the `dtls-echo` example, having that example run into [an assertion][1]. This patch fixes that. [1]: https://github.com/eclipse/tinydtls/blob/bda40789a7c280f248eeca6d09ddd624cdaf5dc8/session.c#L146
maribu
approved these changes
Jul 26, 2022
Member
maribu
left a comment
There was a problem hiding this comment.
ACK. Code looks good, trusting your testing
Member
Author
|
Backport provided in #18371 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
d424aae introduced address families to the RIOT interpretation of tinydtls-
session_ts. However, while fixing the naming for theaddrfield, it did not set thefamilymember for the sessions in thedtls-echoexample, having that example run into an assertion. This patch fixes that.Testing procedure
I used the same script to find the issue to test its fix (assuming you are in
RIOTBASE:It should succeed and its output should contain the following crucial lines:
Issues/PRs references
Follow-up on #17765