tests/periph_timer_short_relative_set: clarify outcome#18513
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Aug 25, 2022
Merged
Conversation
kaspar030
added
the
CI: ready for build
kaspar030
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
github-actions
bot
added
Area: doc
chrysn
approved these changes
Aug 25, 2022
Member
chrysn
left a comment
chrysn
left a comment
There was a problem hiding this comment.
Thanks, this is a good fix.
In parallel, I'll look into making compile_and_test process black/whitelist settings -- it can and should still run these tests, but would annotate them accordingly in the test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Clarify the outcome of
tests/periph_timer_short_relative_set, just so the next tester doesn't get confused/frustrated.Testing procedure
This is purely changing output, so, run
tests/periph_timer_short_relative_setand see it output an additional note on failure.Issues/PRs references
Improves on #12610.
Fixes #18511.