Skip to content

tests/periph_gpio_ll: drop core dump merged by accident#18541

Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom
maribu:core_dumps
Sep 1, 2022
Merged

tests/periph_gpio_ll: drop core dump merged by accident#18541
benpicco merged 2 commits intoRIOT-OS:masterfrom
maribu:core_dumps

Conversation

@maribu
Copy link
Member

@maribu maribu commented Aug 31, 2022

Contribution description

As the title says. It also adds a .gitignore in tests/ and examples/ that matches files named core in a direct subfolder of tests/ and examples/

Testing procedure

$ touch core/foo # should *NOT* be ignored
$ touch core/core # should *NOT* be ignored
$ touch drivers/core # should *NOT* be ignored
$ touch examples/hello-world/core # should be ignored
$ touch tests/unittests/core # should be ignored
$ git add .
$ git status
On branch core_dumps
Your branch is up to date with 'origin/core_dumps'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	new file:   core/core
	new file:   core/foo
	new file:   drivers/core

Issues/PRs references

#16787 (comment)

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Aug 31, 2022
@maribu maribu requested a review from gschorcht August 31, 2022 11:26
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Aug 31, 2022
This will ignore files named `core` and `core.*` (except `core.c`,
`core.h`, `core.md`, `core.txt`) placed directly in the application
folder. This is where `make` is typically called and core dump due to
a crashing native application, flashing tool, or GDB would be placed.
The pattern is intentionally quite narrow, as there is e.g. a core
source folder that should still be monitored.
@maribu
Copy link
Member Author

maribu commented Sep 1, 2022

All green. I updated the .gitignore expressions to also match tests/*/core.* and examples/*/core.* except for core.c, core.h, core.txt and core.md since the ACK. If you agree, please hit merge :)

@benpicco benpicco merged commit bcdf539 into RIOT-OS:master Sep 1, 2022
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
@maribu maribu deleted the core_dumps branch January 21, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants