treewide: Use deprecations in code rather than comments#18565
treewide: Use deprecations in code rather than comments#18565chrysn wants to merge 2 commits intoRIOT-OS:deprecate-in-cfrom
Conversation
Contributes-To: RIOT-OS#18561
| * | ||
| * On modern (C2x) compilers, this expands to the C++11 style attribute | ||
| * `[[deprecated(reason)]]`; otherwise to the GNUism | ||
| * `__((attribute(deprecated))`, or is ignored. |
There was a problem hiding this comment.
| * `__((attribute(deprecated))`, or is ignored. | |
| * `__attribute_((deprecated))`, or is ignored. |
There was a problem hiding this comment.
should be even __attribute__, shouldn't it?
|
If you throw in an |
|
On the severity of errors, I think a good path would be to have Makefiles of On the CI side, Murdock went well because it duly rejected the tests that used the deprecated function (even though, as above, these should later be exempt). Doxygen did not fail but just failed to upload due to timeouts, retrying. |
|
Sadly, doxygen output breaks completely with the current doxygen version -- deprecation text gets moved into functions list, but the function itself is not present any more at all, and the next function is somehow also missing ... putting this in as "waiting for CI update" because the next Ubuntu hopefully has a better Doxygen. (Things looked good with the 1.9.4 I have here). |
|
There was some screw-up with branches -- see #18650 for a follow-up PR. |
Contribution description
This executes #18561.
It already has the macros and Doxygen stuff, it lacks
@deprecatedtoDEPRECATED-Wno-error=deprecated-declarationsif we still want to test the deprecated functions.Testing procedure
Right now:
Long term: