tests/congure_abe: reset node before starting terminal#18769
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 19, 2022
Merged
tests/congure_abe: reset node before starting terminal#18769miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
Fixes synchronization issues on stdio_uart. Copied from the setup function in tests/congure_reno/tests/01-run.py
Murdock results✔️ PASSED 8cf4844 tests/congure_abe: reset node before starting terminal
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
aabadie
approved these changes
Oct 19, 2022
Contributor
aabadie
left a comment
There was a problem hiding this comment.
Looks good and the test is passing now on ci-prod!
ACK
Member
Author
|
The failure of the |
Member
Author
|
Mhh... looking at it again: the test was not executed on $ QUIETER=1 BOARD=samr21-xpro make -C tests/congure_abe/ --no-print-directory -j flash test
Building application "tests_congure_abe" for "samr21-xpro" with MCU "samd21".
[INFO] edbg binary not found - building it from source now
CC= CFLAGS= make -C /home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg
[INFO] edbg binary successfully built!
text data bss dec hex filename
17772 132 2492 20396 4fac /home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.elf
/home/mlenders/Repositories/RIOT-OS/RIOT/dist/tools/edbg/edbg.sh flash /home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_abe/bin/samr21-xpro/tests_congure_abe.bin
### Flashing Target ###
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800005161 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Verification...... done.
Done flashing
.......
----------------------------------------------------------------------
Ran 7 tests in 14.349s
OK(on master I have the same failures as in Murdock) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Fixes synchronization issues on stdio_uart. Copied from the setup function in tests/congure_reno/tests/01-run.py.
See #15968 (comment) ff.
Testing procedure
CI: run testsshould pass on both Murdocks.Issues/PRs references
Follow-up fix on #15968