cpu/thread.c: fix thread_measure_stack_free()#20724
Closed
maribu wants to merge 2 commits intoRIOT-OS:masterfrom
Closed
cpu/thread.c: fix thread_measure_stack_free()#20724maribu wants to merge 2 commits intoRIOT-OS:masterfrom
maribu wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
This fixes a typo in computation in thread_measure_stack_free, which messed up the computation.
github-actions
bot
added
the
Area: core
benpicco
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
benpicco
added
Type: bug
benpicco
previously approved these changes
Jun 4, 2024
miri64
dismissed
benpicco’s stale review
Let's not do the same mistake again, even if you just contributed the test.
miri64
added
the
Process: needs >1 ACK
github-actions
bot
added
the
Process: missing approvals
miri64
approved these changes
Jun 4, 2024
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
ACK, confirmed that this fixed the ps output both on native and nrf52840dongle
Member
Author
|
Closed in favor of #20723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This fixes a typo in computation in thread_measure_stack_free, which messed up the computation.
Testing procedure
Output of
psshould look sane again.Issues/PRs references
Regression of