check-labels.yml: bump to v1.1.2#20727
Merged
chrysn merged 1 commit intoRIOT-OS:masterfrom Jun 5, 2024
Merged
Conversation
miri64
added
the
Type: enhancement
github-actions
bot
added
the
Area: CI
miri64
added
CI: skip compile test
Member
|
Testing this by adding the |
chrysn
added
the
Process: needs >1 ACK
chrysn
approved these changes
Jun 5, 2024
github-actions
bot
added
the
Process: missing approvals
chrysn
approved these changes
Jun 5, 2024
chrysn
removed
the
Process: needs >1 ACK
chrysn
added
CI: ready for build
Member
|
Should the "missing approvals" label have been removed automatically after I removed the requirement for >1 review? |
maribu
approved these changes
Jun 5, 2024
Member
Author
I don't think that the action takes that into account... |
Member
Author
|
More intersting: IIRC "Missing approvals" was checked by bors, but this does not seem to be the case anymore with github-merge-queues :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
There was a bug in the check-labels action that allowed 1 reviewer to give 2 reviews, see RIOT-OS/check-labels-action#2. This is fixed in the latest version, so bump to that.
Testing procedure
Issues/PRs references