tests/sys/shell: use default terminal instead of socat#21058
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Dec 4, 2024
Merged
tests/sys/shell: use default terminal instead of socat#21058maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
python tests by default already use make cleanterm
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
maribu
added
CI: run tests
maribu
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
tests/sys/shellcurrently per default usessocatas terminal, according to the comment to avoid having extra characters put into the IO by the terminal program. But that's exactly whatmake cleantermis for, which is already used per default by the python testrunner.I encountered issues with
socatfor this test (newlines not properly matched against) on boards that useusb_cdc_acmas stdio, while the approach withcleantermworks as expected.Testing procedure
Run the test with some boards using
make -C tests/sys/shell BOARD=xxx flash test. Successfully tested withnative,nrf52840dkandfeather-nrf52840-sense.Issues/PRs references
The commit cdfece6 that introduced the change was merged one and a half months before the introduction of the
cleantermtarget in #12107