sys/net/sock_util: Do not depend on network stack#21419
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom May 5, 2025
Merged
sys/net/sock_util: Do not depend on network stack#21419benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco merged 2 commits intoRIOT-OS:masterfrom
Conversation
Teufelchen1
approved these changes
May 5, 2025
Contributor
Teufelchen1
left a comment
There was a problem hiding this comment.
Nice <3 this has been annoying me for some time!
benpicco
reviewed
May 5, 2025
benpicco
reviewed
May 5, 2025
benpicco
reviewed
May 5, 2025
This allows using and compiling the URL handling functions of sock_util without a network stack used. Co-authored-by: benpicco <benpicco@googlemail.com>
Co-authored-by: benpicco <benpicco@googlemail.com>
Member
Author
|
Thx :) |
Contributor
|
This does break the build with lwIP - turns out we don't have this covered by CI 😕
|
Member
Author
|
I'll have a look later today |
Contributor
|
#21467 should fix this |
Contributor
|
@benpicco thanks for rapid response! |
Contributor
I'm planing a simple client/server example for LWIP IPv4, which could serve as test for such situations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This allows using and compiling the URL handling functions of
sock_utilwithout a network stack used.Specifically, the URL splitting function can be useful even without having a network stack in use, e.g. for exotic CoAP transports (say, CoAP over SMS or CoAP over UART).
Testing procedure
The generated binaries should not change. But including
sock/util.hwithout a network stack should now work without compilation failures.Issues/PRs references
Split out of #21048