pkg/lwip: add LWP_IP4_ADDR_INIT macro#21969
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Jan 12, 2026
Merged
Conversation
github-actions
bot
added
Area: network
krzysztof-cabaj
force-pushed
the
lwip_utils_addr_init_macro
branch
from
466eddd to
4830f3a
Compare
crasbe
added
Type: new feature
Member
|
This initializes a data type defined by lwIP upstream. Why not provide it there (and in the meantime until the next release, add a patch to the package)? |
Contributor
Author
|
Ok. This is a good idea. I prepare PR for LWIP and when I have it - I provide appropriate patch in this PR. |
krzysztof-cabaj
force-pushed
the
lwip_utils_addr_init_macro
branch
from
4830f3a to
6ddf4f5
Compare
miri64
approved these changes
Jan 12, 2026
Contributor
Author
|
@miri64 Thanks for idea and support with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds
LWIP_IP4_ADDR_INITmacro which could be used for setting LWIPip4_addr_taddress.This macro is similar to
IPV4_ADDR_INITforipv4_addr_tand the issue was spotted in PR #21519 see comment.update 2025.01.09
Currently as @miri64 suggested I add this macro as a patch for LWIP package. To be aligned with LWIP naming, current name of the macro is
IP4_ADDR_INIT. The code from the patch is added in PR for LWIP github repository - see for details.Testing procedure
I use this macro in
examples/lwip_ipv4- check if everything still works.Issues/PRs references
PR #21519