Skip to content

sys: xtimer: WIP: xtimer refactoring#5355

Closed
malosek wants to merge 1 commit intoRIOT-OS:masterfrom
malosek:xtimer_refactoring
Closed

sys: xtimer: WIP: xtimer refactoring#5355
malosek wants to merge 1 commit intoRIOT-OS:masterfrom
malosek:xtimer_refactoring

Conversation

@malosek
Copy link
Contributor

@malosek malosek commented Apr 19, 2016

Hello,

addressing issue reported in #4902. The idea is to get rid of timer_set_absolute with 32bits target.
Now all the magic happens in _xtimer_set64 where there is irq disabled between getting the current absolute time and target calculations.
have had look at xtimer_sleep_until as well - not to duplicate code from _xtimer_sleep and use 64bits last_wakeup arg.

It it still WIP (need to adapt the rest of the sources for new xtimer_sleep_until arg), but would like to get general feedback.

wbr
malo

Signed-off-by: malo <malo@25cmsquare.io>
@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: timers Area: timer subsystems labels Apr 19, 2016
@kYc0o kYc0o added this to the Release 2016.07 milestone Apr 19, 2016
@kaspar030
Copy link
Contributor

We have to solve #5338 first, otherwise, disableIRQ(), xtimer_now64() doesn't work as the overflow interrupt might get lost.

@kaspar030
Copy link
Contributor

@malosek Can you take a look at #5428? It contains some ideas from this PR and should also fix #4902.

@malosek
Copy link
Contributor Author

malosek commented May 11, 2016

Hello @kaspar030 ,
quite a rework - finally:), looking forward, will try to give it play in "near" future.
wbr
malo

@kYc0o
Copy link
Contributor

kYc0o commented Jul 22, 2016

@kaspar030 @gebart are these fixes addressed by one of your PRs? Can you take a look?

@jnohlgard
Copy link
Member

I think #5428 will fix this, @kaspar030 what do you think?

@kYc0o
Copy link
Contributor

kYc0o commented Jul 27, 2016

As #5428 was postponed, I think this one needs that too, however we could also look if that PR is addressing the same issue as this one.

@kYc0o kYc0o modified the milestones: Release 2016.10, Release 2016.07 Jul 27, 2016
@miri64
Copy link
Member

miri64 commented Oct 31, 2016

#5428 was postponed so this one needs to go too (+ Kaspar is on vacation)

@miri64 miri64 modified the milestones: Release 2017.01, Release 2016.10 Oct 31, 2016
@OlegHahm
Copy link
Member

What's the state of this PR?

@kYc0o
Copy link
Contributor

kYc0o commented Jan 16, 2017

Maybe #5607 #5608 and #5612 solved (partially) this?

@PeterKietzmann PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Mar 3, 2017

I'd like to know if we can close this PR if the fixes it provides are already addressed by already merged PRs...

@smlng
Copy link
Member

smlng commented Mar 3, 2017

IMHO this PR is quite outdated, it doesn't use the xtimer_ticks32/64 types and is way before the major rework done in #5608.

+1 for closing

@malosek
Copy link
Contributor Author

malosek commented Mar 13, 2017

closing...

wbr
malo

@malosek malosek closed this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: timers Area: timer subsystems State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants