cpu: Add PIC32MX Support by neiljay · Pull Request #6092 · RIOT-OS/RIOT

neiljay · 2016-11-09T10:55:32Z

~~This PR is dependant on #6060 and #6066.~~

Add support for PIC32 MX devices which use a MIPS M4K core.

This PR adds basic support for Microchip PIC32MX devices, including
bootstrapping the device, the build system produces a hex image loadable via
MPLAB-IPE. It has been tested on a MikroE Clicker board.

NOTE: This port requires the use of the GCC based MIPS Codescape SDK toolchain
available here:

https://community.imgtec.com/developers/mips/tools/codescape-mips-sdk/download-codescape-mips-sdk-essentials/

You cannot use Microchip's MPLAB / Harmony tools to build this port.

The port has been tested with the following examples:
hello-world
ipc_pingpong
timer_periodic_wakeup
riot_and_cpp

Note this is a re-work of #5885 with review comments addressed but now broken down into 3 separate PR's of which this is the third (and final).

OlegHahm · 2016-11-21T16:16:34Z

We have received the PICkit3, but I'm still struggling to flash the device from Linux. Not sure which tool I need to install and the flash target also doesn't seem to be defined.

neiljay · 2016-11-21T16:25:44Z

You need MPLAB-IPE:

http://www.microchip.com/mplabx-ide-linux-installer

http://microchip.wikidot.com/ipe:installation

I have stopping using MPLAB though and I'm using this instead (written
by a college of mine):

https://github.com/sergev/pic32prog

The only issue with this, is you have to reflash the firmware on the
pickit-3 to scripting mode, which can only be done with a windows app
(it only has to be done once though):

http://ww1.microchip.com/downloads/en/DeviceDoc/PICkit3%20Programmer%20Application%20v3.10.zip

Neil

On 11/21/16 16:16, Oleg Hahm wrote:

We have received the PICkit3, but I'm still struggling to flash the
device from Linux. Not sure which tool I need to install and the |flash|
target also doesn't seem to be defined.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6092 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AUEU6hY9jCfv80hr8whZYguerWiC8ssqks5rAcPlgaJpZM4KtZ6Y.

OlegHahm · 2016-11-21T16:27:43Z

Thanks for the super fast response. I'm currently following this guide: http://www.electropepper.org/blog/item/linux-terminal-only-pic-programming

If this doesn't work, I will try to see if I can find a Windows computer.

neiljay · 2016-11-21T16:33:00Z

You could try pickle if you have a Ci40 as well:

https://docs.creatordev.io/clicker/guides/quick-start-guide/#programming-a-6lowpan-clicker

Some more help here:

https://docs.creatordev.io/wifire/guides/wifire-programming/

Neil

On 11/21/16 16:27, Oleg Hahm wrote:

Thanks for the super fast response. I'm currently following this guide:
http://www.electropepper.org/blog/item/linux-terminal-only-pic-programming

If this doesn't work, I will try to see if I can find a Windows computer.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6092 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AUEU6osguHxTepe__7rEI_eD34Yy_yKBks5rAcaDgaJpZM4KtZ6Y.

OlegHahm · 2016-11-21T17:39:27Z

Couldn't get the Clicker to get programmed, but at least the Wifire. Maybe I connected the pins wrong.

neiljay · 2016-11-21T17:52:07Z

My board has resistor links on the back to select between ICSP (pickit)
and mProg (some MikroE standard), J3,J4,J5. Send me a picture of your
board so I can check against mine.

On 11/21/16 17:39, Oleg Hahm wrote:

Couldn't get the Clicker to get programmed, but at least the Wifire.
Maybe I connected the pins wrong.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6092 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AUEU6vpX8T9gEzHye2QpnM0IQzTGLdRFks5rAddTgaJpZM4KtZ6Y.

OlegHahm · 2016-12-08T18:37:17Z

Will try to come back to this next week.

kYc0o · 2017-01-18T22:21:01Z

Lately the weeks are getting looooooong...

neiljay · 2017-02-14T14:22:22Z

@kaspar030 @cgundogan

Hi there seems to be something odd going on with the CI system.
The pic32-wifire, pic32-clicker and mips-malta boards share common code, but the CI appears to trigger parallel builds of these boards in the same directory, from last run:

/opt/jenkins/workspace/RIOT_PR_PR-6092-SJA35D5NQ53ATHG7JEZVLUVZD4XF653KSXZJCQIBIKAGQUBXUZUA/jenkins_bin/

(used by mips-malta and pic32-clicker)

Which results in random build failures each time the CI is run.

kaspar030

minor nitpicks about the license header blocks
some possible code duplication

Looking forward to have "real" mips boards supported! ;)

kaspar030 · 2017-02-14T16:17:41Z

cpu/mips_pic32_common/periph/uart.c

@@ -0,0 +1,76 @@
+/*
+ * Copyright 2016, Imagination Technologies Limited and/or its


kaspar030 · 2017-02-14T16:18:22Z

cpu/mips_pic32_common/periph/uart.c

+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */


Please add a newline after each license block. (This file and some others)

kaspar030 · 2017-02-14T16:20:42Z

cpu/mips_pic32mz/include/cpu.h

@@ -0,0 +1,52 @@
+/*
+ * Copyright 2016, Imagination Technologies Limited and/or its
+ *                 affiliated group companies.


Here and other files: please add newline before license text.

kaspar030 · 2017-02-14T16:21:36Z

cpu/mips_pic32mz/p32mz2048efg100/Makefile

@@ -0,0 +1,3 @@
+MODULE = p32mz2048efg100


No need for MODULE if the name equals the folder name.

kaspar030 · 2017-02-14T16:23:07Z

cpu/mips_pic32mz/Makefile.include

@@ -0,0 +1,69 @@
+ifndef MIPS_ELF_ROOT


IIRC this file looks a lot like cpu/mips32r2_common/Makefile.include. Is it possible to share similarities?

neiljay · 2017-02-14T16:54:49Z

@kaspar030 Should be easy to address these issues.

Can you remove the "waiting for other PR tag" now the common mips code is merged. Ta.

neiljay · 2017-02-15T15:36:27Z

@kaspar030 If your happy with the copyright changes I'll squash those down.
Also see how the build fails in CI/Jenkins but works in Murdock. #6066 builds fine in Jenkins presumable as its just one board not 2 ??

neiljay · 2017-02-21T14:36:37Z

@kaspar030 happy for me to squash these ?

neiljay · 2017-03-29T14:55:07Z

Rebased, Squashed, Dependants merged, 3 ticks, time to merge I think ;-)

jnohlgard · 2017-03-30T07:14:43Z

I see an ACK and three greens.
@neiljay is you intent to refactor the ldscripts in a follow up? (referring to #6092 (comment))

neiljay · 2017-03-30T09:08:04Z

Yes, might as well do this all in one place instead of holding this up.

…

On 03/30/17 08:14, Joakim Nohlgård wrote: I see an ACK and three greens. @neiljay <https://github.com/neiljay> is you intent to refactor the ldscripts in a follow up? (referring to #6092 (comment) <#6092 (comment)>) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6092 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUEU6s5OqU3DLiOsg0BUXEii4tqD6NPWks5rq1ZngaJpZM4KtZ6Y>.

neiljay · 2017-03-30T09:08:20Z

Thanks all !

…

On 03/30/17 08:16, Joakim Nohlgård wrote: Merged #6092 <#6092>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6092 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUEU6kcSYlHwDR_aYOdWbK-n8v9FT2okks5rq1a-gaJpZM4KtZ6Y>.

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

Note: in contrast to mips-malta, these boards are still available for purchase. This means that if the issued listed below were to be fixed (and the boards maintained by a person versed in the architecture) then adding them back would be a valid possibility. The pic32-clicker and pic32-wifire have severe issues affecting their usability, maintainability and have no maintainer. 1. Usability ============ I doubt the current implementation of these board can be use for any serious development. This is a problem with MIPS-RIOT integration in general and was explained in the PR removing mips-malta: > a. Makes development & debugging way harder. > b. It is impossible to run interactive tests. > b.1. Constrains the rest of the platforms by providing an incentive to not > make tests interactive. > c. The lack of UART is a witness to the poor quality of the port. This alone should have been enough reson not to merge this boards in the first place. pic32-wifire is the least worse. At least it can be flashed from Linux, though it is not an easy task. From dist/tools/pic32prog/doc.md >It will require flashing a specific firmware on the PICkit3. > As this can only be done from a Windows computer, that not many Linux users > have, the following steps explain how to setup a Windows VirtualBox virtual > machine and flash the PICkit3 from it. > > Informations come from this comment > > RIOT-OS#6092 (comment) pic32-clicker HAS NO FLASHER and requires one to use MPLAB. 2. No maintainer ================ There is no (active) RIOT maintainer with deep knowledge of the boards and platform. A quick search through the issues and PRs shows this. 3. Maintainability ================== As a consequence of (1) and (2) many tests are not run in these boards. At the same time, RIOT maintainers - especially those working on the build system - still have to modify and migrate mips-foo boards. The rest of the arguments here are the same as presented with the mips-malta removal.

Define a RIOT_PIC32PROG to allow setting 'PIC32PROG' globally from environment. https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

miri64 added Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Nov 10, 2016

miri64 assigned haukepetersen Nov 10, 2016

miri64 added this to the Release 2017.01 milestone Nov 10, 2016

OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 21, 2016

PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017

neiljay force-pushed the pr/add_mips_pic32mx branch 2 times, most recently from 2ea04a6 to 390ab20 Compare February 14, 2017 13:41

kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 14, 2017

kaspar030 requested changes Feb 14, 2017

View reviewed changes

kaspar030 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 14, 2017

neiljay force-pushed the pr/add_mips_pic32mx branch 2 times, most recently from a13e366 to 1c827f3 Compare February 15, 2017 14:46

neiljay mentioned this pull request Feb 15, 2017

mips: Build system is not aligned with other platforms #6588

Closed

4 tasks

neiljay mentioned this pull request Feb 24, 2017

cpu/mips: Integrate better with RIOT newlib layer #6639

Closed

jnohlgard merged commit 1a9b12f into RIOT-OS:master Mar 30, 2017

cladmi added a commit to cladmi/RIOT that referenced this pull request May 31, 2018

pic32prog.inc.mk: add support for pic32prog flasher

22965ff

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

This was referenced May 31, 2018

pic32-wifire: add support for flashing with pic32prog #9259

Merged

pic32prog: add a documentation on how to update PICkit3 #9260

Merged

cladmi added a commit to cladmi/RIOT that referenced this pull request Jun 15, 2018

pic32prog.inc.mk: add support for pic32prog flasher

15db86e

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jun 27, 2018

pic32prog.inc.mk: add support for pic32prog flasher

4a7f826

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jul 2, 2018

pic32prog.inc.mk: add support for pic32prog flasher

0c1a0ea

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jul 2, 2018

pic32prog.inc.mk: add support for pic32prog flasher

49cf996

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jul 5, 2018

pic32prog.inc.mk: add support for pic32prog flasher

b0a4394

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jul 17, 2018

pic32prog.inc.mk: add support for pic32prog flasher

e75ac22

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jul 17, 2018

pic32prog.inc.mk: add support for pic32prog flasher

646bc17

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Aug 16, 2018

pic32prog.inc.mk: add support for pic32prog flasher

1f2e1ea

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Aug 20, 2018

pic32prog.inc.mk: add support for pic32prog flasher

9bdeaf7

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Nov 19, 2018

pic32prog.inc.mk: add support for pic32prog flasher

43705af

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Dec 6, 2018

pic32prog.inc.mk: add support for pic32prog flasher

7fc410f

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jan 21, 2019

pic32prog.inc.mk: add support for pic32prog flasher

87f391c

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Mar 6, 2019

pic32prog.inc.mk: add support for pic32prog flasher

80c6757

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jun 3, 2019

pic32prog.inc.mk: add support for pic32prog flasher

fc12f4d

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jun 17, 2019

pic32prog.inc.mk: add support for pic32prog flasher

1caaec8

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

cladmi added a commit to cladmi/RIOT that referenced this pull request Jun 25, 2019

pic32prog.inc.mk: add support for pic32prog flasher

a903212

https://github.com/sergev/pic32prog For PICkit3 it requires having it with scripting mode firware. Source ------ RIOT-OS#6092 (comment)

jcarrano mentioned this pull request Jul 3, 2019

cpu/mips: Remove platform #11788

Closed

		@@ -0,0 +1,76 @@
		/*
		* Copyright 2016, Imagination Technologies Limited and/or its

Conversation

neiljay commented Nov 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlegHahm commented Nov 21, 2016

Uh oh!

neiljay commented Nov 21, 2016

Uh oh!

OlegHahm commented Nov 21, 2016

Uh oh!

neiljay commented Nov 21, 2016

Uh oh!

OlegHahm commented Nov 21, 2016

Uh oh!

neiljay commented Nov 21, 2016

Uh oh!

OlegHahm commented Dec 8, 2016

Uh oh!

kYc0o commented Jan 18, 2017

Uh oh!

neiljay commented Feb 14, 2017

Uh oh!

kaspar030 left a comment

Choose a reason for hiding this comment

Uh oh!

kaspar030 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 Feb 14, 2017

Choose a reason for hiding this comment

Uh oh!

neiljay commented Feb 14, 2017

Uh oh!

neiljay commented Feb 15, 2017

Uh oh!

neiljay commented Feb 21, 2017

Uh oh!

neiljay commented Mar 29, 2017

Uh oh!

jnohlgard commented Mar 30, 2017

Uh oh!

neiljay commented Mar 30, 2017 via email

Uh oh!

neiljay commented Mar 30, 2017 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

neiljay commented Nov 9, 2016 •

edited

Loading