Conversation
directory rework note directory change in help printout, update .gitignore Update help print outs in scripts update .gitignore for --no-cleanup testing
kaleb-himes
force-pushed
the
wolfSSL-ALPHA
branch
from
a1a705d to
1f7da51
Compare
LudwigKnuepfer
added
the
Type: new feature
|
Some comments:
|
LudwigKnuepfer
added
State: WIP
|
Hi LudwigKnuepfer,
|
|
As Ludwig suggests, this kind of new features should be located on the pkg/ folder, where you add some Makefiles which will download automatically the new code, add some patches if necessary and compile it (either using RIOT's compiling rules or upstream, you can get examples of this in any pkg_* prefixed test). The test should be located under tests/ on which the Makefile should use the associated pkg (look for instance to tests prefixed by pkg_* on the tests folder) and eventually a main program performing the tests. As far as I can see, everything is based on scripts which will do the job, which is not very common in RIOT, but neither is forbidden nor non-recommended. I'd like to have the opinion of @OlegHahm or @kaspar030 on this. Whenever possible, we prefer Markdown readme, but that's just a detail. Commits should be also prefixed by the place where they are modifying/adding code, for instance: tests/wolfSSL: adding wolfSSL package tests Any commit addressing reviewers comments should not be squashed until the reviewer ACK your PR. Those commits can have any name and description. I'll test it asap and give feedback, but this PR needs to reorganise the way wolfSSL is added to RIOT before getting merged. Thanks for your contribution! |
While this procedure is not explicitly "forbidden", I would vote against introducing it this way. @kaleb-himes, is there any reason against introducing wolfSSL as a package? IMO this is way more convenient for an application developer. With the proposed method in this PR an application developer who wants to use wolfSSL on top of RIOT would need to locate and copy over the script from the test folder instead of simply adding |
|
Excellent suggestions! I will research your documentation on how to create a package in this manner. I agree that would be far more convenient from a developer standpoint to be able to add Thank you so much for all the feedback and helpful commentary thus far! |
|
Great! Let us know if you have problems or questions regarding the documentation and creating a package. We will happily help you and may have a chance to improve the docs. |
|
Thank you, will do! |
|
@kaleb-himes what's the latest on this? |
|
We have been extremely busy since the 1st of the year and it has severely impacted my progress on this. No rush before your release, it may be some time before I am free to look into generating the requested "package". We have RSA 2017 quickly approaching and many paid projects in the queue! Once we get some breathing room again this will be one of the first things on our to-do list. If at all possible wolfSSL is happy to start with what we already submitted, gather user feedback, and put out a package, per your request, in a few months or at the earliest convenience. Warmest Regards, Kaleb |
|
People are asking for the progress of this PR ;-) https://twitter.com/wolfSSL/status/857376741706186752 |
|
Ping? |
|
Hi @kaleb-himes! Do you have some progress on this PR? |
|
|
||
| # wolfSSL security | ||
| tests/security/wolfssl | ||
| tests/security/*/*.c |
There was a problem hiding this comment.
Not sure this should be here... If while performing your test you download the package as other tests do, the sources are automatically ignored.
| CFLAGS += -DBENCH_EMBEDDED | ||
|
|
||
| #ignore warnings on empty translation units due to wolfSSL configurability | ||
| WERROR = 0 |
There was a problem hiding this comment.
This should not be used in a test.
|
Closing this pull request based on feedback. wolfSSL has instead created a "PKG" solution and opened a new PR. See new PR here: #7348 |
7 participants
These examples have only been tested successfully on MAC OS X using the following toolchain:
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.1.0
Thread model: posix
This is strictly an alpha release to allow the RIOT-OS community and wolfSSL community to begin collaborating! There may be portability issues if building with another gcc version. Please report all issues and direct all development related questions to support@wolfssl.com
For all other questions please contact info@wolfssl.com
We look forward to working with RIOT-OS community to provide an IoT friendly ssl/tls and/or cryptographic solution!
wolfSSL can be compiled for cryptography only by adding
WOLFCRYPT_ONLYto CFLAGS