Skip to content

mtd: Redefine MTD_0 as a mtd_dev_t *#6808

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/vfs-mtd0-ptr
Mar 28, 2017
Merged

mtd: Redefine MTD_0 as a mtd_dev_t *#6808
miri64 merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/vfs-mtd0-ptr

Conversation

@jnohlgard
Copy link
Member

Unconditional casting in tests-mtd can hide programmer mistakes, such as accidentally giving a mtd_dev_t ** instead of mtd_dev_t *
(I caused some hardfaults with this when trying out #6762 on Mulle)

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 28, 2017
@jnohlgard jnohlgard added this to the Release 2017.04 milestone Mar 28, 2017
Copy link
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 5928de0 into RIOT-OS:master Mar 28, 2017
@jnohlgard jnohlgard deleted the pr/vfs-mtd0-ptr branch September 24, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants