boards/nucleo-common: fix on-board LED macro for nucleo-f302 case#7490
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Aug 24, 2017
Merged
boards/nucleo-common: fix on-board LED macro for nucleo-f302 case#7490smlng merged 1 commit intoRIOT-OS:masterfrom
smlng merged 1 commit intoRIOT-OS:masterfrom
Conversation
aabadie
added
Platform: ARM
aabadie
added
the
CI: ready for build
smlng
suggested changes
Aug 22, 2017
| * @{ | ||
| */ | ||
| #ifdef CPU_MODEL_STM32F302R8 | ||
| #define LED0_GPIO GPIOB |
Member
There was a problem hiding this comment.
inconsistent naming, in other places this is called LED0_PORT
Contributor
Author
There was a problem hiding this comment.
No this is different from port: here it's PORT_B. This macro targets the GPIO port address directly.
I made the same confusion when working on #6991.
Member
There was a problem hiding this comment.
what's the difference to here which uses LED0_PORT not LED0_GPIO as you proposed. My point is not LEDx_GPIO vs. LEDx_PORT but rather that is should be consistently named in RIOT.
Contributor
Author
There was a problem hiding this comment.
aabadie
force-pushed
the
nucleo_f302_led_fix
branch
from
6068f63 to
24a12da
Compare
Contributor
Author
|
@smlng ? |
smlng
approved these changes
Aug 24, 2017
Member
|
ACK and GO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of nucleo-f302, the on-board LED macro was misconfigured. This PR fixes that.