xtimer: Add reference point for _xtimer_set_absolute#7630
Closed
jnohlgard wants to merge 10 commits intoRIOT-OS:masterfrom
Closed
xtimer: Add reference point for _xtimer_set_absolute#7630jnohlgard wants to merge 10 commits intoRIOT-OS:masterfrom
jnohlgard wants to merge 10 commits intoRIOT-OS:masterfrom
Conversation
added 10 commits
September 19, 2017 14:01
When the target is inside the next long_period, the previous condition was incorrect. The new condition should give the same result regardless of whether there is a long_period tick coming soon or not.
Avoids a possible race condition in xtimer_set, xtimer_periodic where the target time will have already passed when execution reaches the _xtimer_now() call inside _xtimer_set_absolute. The race condition is more easily triggered in xtimer_periodic because of the longer execution time, but it is possible inside xtimer_set as well if an interrupt arrives before the _xtimer_set_absolute call and the ISR is non-trivial, and/or a context switch is triggered by the ISR.
jnohlgard
added
Type: bug
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a possible race condition in xtimer_set, xtimer_periodic where the target time will have already passed when execution reaches the _xtimer_now() call inside _xtimer_set_absolute. The race condition is more easily triggered in xtimer_periodic because of the longer execution time, but it is possible inside xtimer_set as well if an interrupt arrives before the _xtimer_set_absolute call and the ISR is non-trivial, and/or a context switch is triggered by the ISR.
Based on top of #7496, #7628