Skip to content

boards/arduino-mkrwan1300: add initial support (without LoRa)#8354

Merged
aabadie merged 5 commits intoRIOT-OS:masterfrom
aabadie:board/mkrwan1300
Oct 3, 2019
Merged

boards/arduino-mkrwan1300: add initial support (without LoRa)#8354
aabadie merged 5 commits intoRIOT-OS:masterfrom
aabadie:board/mkrwan1300

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 12, 2018

Contribution description

This PR adds support for the Arduino MKR WAN 1300 board that was released at the end of last year.

The LoRa module is a Murata chip. This is the same one that is on the ST b-l072z-lrwan1 but on the Arduino board, it's controlled using AT commands on one of the MCU UART.

For better integration with other MKR boards and to avoid too much code duplication (because there one more UART and one SPI less than others) I had to slightly refactor the periph configuration header.

I also started to write a driver for the LoRa module but it doesn't work yet. I'm trying to base it on #7084.

I'm also planning to add the support for the Arduino MKR GSM 1400, will PR this soon.

Issues/PRs references

None

@aabadie aabadie added Area: arduino API Area: Arduino wrapper API Area: LoRa Area: LoRa radio support Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 12, 2018
@aabadie aabadie changed the title boards/arduino-mkrwan1300: add initial support boards/arduino-mkrwan1300: add initial support (without LoRa) Jan 12, 2018
@aabadie aabadie added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jan 12, 2018
@aabadie aabadie force-pushed the board/mkrwan1300 branch 2 times, most recently from 81c4683 to 11fc318 Compare May 25, 2018 08:05
@aabadie aabadie mentioned this pull request Jun 4, 2018
Closed
@tcschmidt tcschmidt requested a review from jia200x June 11, 2018 09:04
@jia200x
Copy link
Member

jia200x commented Jun 11, 2018

It looks good to me. Unfortunately I don't have any boards to test.

@aabadie aabadie force-pushed the board/mkrwan1300 branch from 11fc318 to d013831 Compare June 19, 2018 11:28
@miri64 miri64 removed the Area: arduino API Area: Arduino wrapper API label Sep 1, 2018
@aabadie
Copy link
Contributor Author

aabadie commented Oct 12, 2018

Rebased and adapted after I2C rework. Anyone willing to review this ?

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@aabadie aabadie added State: don't stale State: Tell state-bot to ignore this issue and removed State: stale State: The issue / PR has no activity for >185 days labels Aug 11, 2019
@aabadie aabadie removed the State: don't stale State: Tell state-bot to ignore this issue label Sep 19, 2019
@aabadie aabadie requested a review from fjmolinas September 19, 2019 18:07
fjmolinas
fjmolinas reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Minor comment.

I'm going to run tests using #12304 to automate flashing.

@fjmolinas
Copy link
Contributor

fjmolinas commented Sep 30, 2019 •
edited
Loading

I'm going to run tests using #12304 to automate flashing.

Ok so it didn't work as expected because all tests with no sync failed (since there is no reset signal).

I verified the result for all tests/periph_xxx and xtimer_**. I think this is enough for now, for it to be east to be run all tests on this kind of board a couple of issue need to be addressed in separate PR's (namely syncing at the start of every test, having a different programmer and terminal port).

@aabadie please squash.

aabadie added 2 commits October 3, 2019 09:24
@aabadie
boards/common/arduino-mkr: split periph_conf file
7bfe086 
- periph_conf_common.h contains peripherals configuration common to all mkr boards
- periph_conf.h is specific to a subset of mkr boards (mkr1000 and mkrzero)
@aabadie
boards/common/arduino-mkr: use common LED0_NAME definition
f776343
@aabadie
Copy link
Contributor Author

aabadie commented Oct 3, 2019

squashed!

fjmolinas
fjmolinas approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@aabadie
Copy link
Contributor Author

aabadie commented Oct 3, 2019

It seems there are new static tests that need to be fixed :)

Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
	Makefiles files from cpu must not be included by the board anymore
		boards/arduino-mkrwan1300/Makefile.features:-include $(RIOTCPU)/samd21/Makefile.features

@aabadie
Copy link
Contributor Author

aabadie commented Oct 3, 2019

Fixed the static test failure, all green now. Let's go. Thanks for reviewing and testing @fjmolinas !

@aabadie aabadie merged commit 9659eec into RIOT-OS:master Oct 3, 2019
@aabadie aabadie deleted the board/mkrwan1300 branch October 3, 2019 07:59
@kb2ma kb2ma added this to the Release 2019.10 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@jia200x jia200x Awaiting requested review from jia200x

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2019.10

Development

Successfully merging this pull request may close these issues.

5 participants

@aabadie @jia200x @fjmolinas @miri64 @kb2ma