cpu/efm32/periph/timer: remove timer_set duplicate#8718
Merged
basilfx merged 1 commit intoRIOT-OS:masterfrom Mar 1, 2018
Merged
cpu/efm32/periph/timer: remove timer_set duplicate#8718basilfx merged 1 commit intoRIOT-OS:masterfrom
basilfx merged 1 commit intoRIOT-OS:masterfrom
Conversation
timer_set is already provided by 'periph_common' so does not need to be provided by cpu/periph.
cladmi
added
Impact: minor
cladmi
added
the
CI: ready for build
Contributor
Author
|
I have not tested that the board still works. Only compiled. |
basilfx
approved these changes
Mar 1, 2018
Member
basilfx
left a comment
basilfx
left a comment
There was a problem hiding this comment.
Tested on STK3600 using tests/periph_timer.
ACK.
Contributor
Author
|
Thanks you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timer_set is already provided by 'periph_common' so does not need to be
provided by cpu/periph.
The build system currently silently ignores this.
Issues/PRs references
Its required for #8711
It was also disabled by #5757 in
periph_conf.hbut the function can be removed as its identical toperiph_commonhttps://github.com/RIOT-OS/RIOT/blob/2018.01/drivers/periph_common/timer.c#L24.