Skip to content

bindist: remove APPLICATION_MODULE duplicate#8818

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/ld/bindist_fix_application_module_duplicate
Mar 22, 2018
Merged

bindist: remove APPLICATION_MODULE duplicate#8818
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/ld/bindist_fix_application_module_duplicate

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Mar 22, 2018

Contribution description

Fix APPLICATION_MODULE being duplicated in the command line during link.

This error is currently silently ignored by the linker.

Issues/PRs references

This is a preliminary fix required for #8711

Fix APPLICATION_MODULE being duplicated in the command line during link.

This error is currently silently ignored by the linker.
@cladmi cladmi added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 22, 2018
@cladmi cladmi requested review from jnohlgard and kaspar030 March 22, 2018 13:37
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 0f19bdd into RIOT-OS:master Mar 22, 2018
@cladmi cladmi deleted the pr/ld/bindist_fix_application_module_duplicate branch March 22, 2018 13:55
@cladmi cladmi added this to the Release 2018.04 milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants