Skip to content

robotis-loader.py: fix flake8 errors#8903

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/robotis-loader/flake8
Apr 9, 2018
Merged

robotis-loader.py: fix flake8 errors#8903
aabadie merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/robotis-loader/flake8

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Apr 9, 2018

Contribution description

When writing #8838 I got already existing flake8 errors as it was modified.
I fixed the semicolon and lazily silenced the 'bare-except'.

It removes the following warnings:

boards/opencm904/dist/robotis-loader.py:85:1: E722 do not use bare except'
boards/opencm904/dist/robotis-loader.py:91:1: E722 do not use bare except'
boards/opencm904/dist/robotis-loader.py:101:16: E703 statement ends with a semicolon
boards/opencm904/dist/robotis-loader.py:60:1: E265 block comment should start with '# '
boards/opencm904/dist/robotis-loader.py:62:1: E265 block comment should start with '# '

Issues/PRs references

Used in #8838

@cladmi cladmi added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 9, 2018
@cladmi cladmi requested a review from aabadie April 9, 2018 16:46
I fixed the errors and lazily silenced the 'bare-except'.

    boards/opencm904/dist/robotis-loader.py:85:1: E722 do not use bare except'
    boards/opencm904/dist/robotis-loader.py:91:1: E722 do not use bare except'
    boards/opencm904/dist/robotis-loader.py:101:16: E703 statement ends with a semicolon
    boards/opencm904/dist/robotis-loader.py:60:1: E265 block comment should start with '# '
    boards/opencm904/dist/robotis-loader.py:62:1: E265 block comment should start with '# '
@cladmi cladmi force-pushed the pr/robotis-loader/flake8 branch from 046b745 to a1ea4cd Compare April 9, 2018 16:56
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go!

@aabadie aabadie merged commit d627bcd into RIOT-OS:master Apr 9, 2018
@cladmi cladmi deleted the pr/robotis-loader/flake8 branch April 10, 2018 13:31
@cladmi cladmi added this to the Release 2018.04 milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants