Skip to content

Test murdock failed to detect bug in Makefile#8912

Closed
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
cladmi:pr/murdock/fail_to_detect_missing_target
Closed

Test murdock failed to detect bug in Makefile#8912
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
cladmi:pr/murdock/fail_to_detect_missing_target

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Apr 10, 2018

Contribution description

Murdock was not finding the problem described in #8910

Reason is that archives files are kept between build, and so when running make clean all the files exist and make did not complain. (I mixed with buildtest command)

As murdock is run with clean all, there is a rule that say $(BASELIBS) (other_stuff): clean so make was not complaining.

The goal of this PR is just to show that it fails in murdock without fix in #8911

Issues/PRs references

Issue #8910

@cladmi cladmi added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools labels Apr 10, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Apr 10, 2018

I modified the wrong file before…

@cladmi
Copy link
Contributor Author

cladmi commented Apr 10, 2018

Yeah, build is failing as expected.
This should not be mergedl, it is only to show that #8911 fixes work in murdock when doing make clean; make all.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 13, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Apr 18, 2018

Not needed anymore, it was only to show #8911 fixed the problem.

@cladmi cladmi closed this Apr 18, 2018
@cladmi cladmi deleted the pr/murdock/fail_to_detect_missing_target branch April 19, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants