Test murdock failed to detect bug in Makefile#8912
Closed
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
Test murdock failed to detect bug in Makefile#8912cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
cladmi wants to merge 3 commits intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
I modified the wrong file before… |
Contributor
Author
|
Yeah, build is failing as expected. |
Contributor
Author
|
Not needed anymore, it was only to show #8911 fixed the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Murdock was not finding the problem described in #8910
Reason is that archives files are kept between build, and so when running(I mixed with buildtest command)make clean allthe files exist and make did not complain.As murdock is run with
clean all, there is a rule that say$(BASELIBS) (other_stuff): cleanso make was not complaining.The goal of this PR is just to show that it fails in murdock without fix in #8911
Issues/PRs references
Issue #8910